Use Object.hash instead of hashValues #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irvine5k
changed the title
|
Fixes #1430 |
|
can you remove all formatting changes? Maybe also go with |
irvine5k
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
irvine5k
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
|
@felix-ht you're correct, I misread and it's Object.hash. I removed the formatting changes as well. |
irvine5k
changed the title
|
I'm getting an error on animateCamera using this PR, no idea if it is from the changes, the new flutter version or the way I added the PR to the dependencies (#1430 (comment)). (Weirdly enough the error is only happening in --profile or --release mode) |
|
@TBA-Lucas It doesn't seem to be related to this PR. Seems that the @felix-ht do you anything about it? @override
Future<bool?> animateCamera(CameraUpdate cameraUpdate,
{Duration? duration}) async {
final cameraOptions = Convert.toCameraOptions(cameraUpdate, _map);
final around = getProperty(cameraOptions, 'around');
final bearing = getProperty(cameraOptions, 'bearing');
final center = getProperty(cameraOptions, 'center');
final pitch = getProperty(cameraOptions, 'pitch');
final zoom = getProperty(cameraOptions, 'zoom');
_map.flyTo({
if (around.jsObject != null) 'around': around, // around is probably null at some point.
if (bearing != null) 'bearing': bearing,
if (center.jsObject != null) 'center': center,
if (pitch != null) 'pitch': pitch,
if (zoom != null) 'zoom': zoom,
if (duration != null) 'duration': duration.inMilliseconds,
});
return true;
} |
|
This issue causing a lot of problems with new flutter version. Please update the package and merge this PR. |
|
When this can be merged? |
Is this related on your PR? |
|
@moshOntong-IT maybe it’s due the fact that the inner packages points to this repository which is broken while I fixed locally pointing to my branch which has the fix, but I can’t make this PR points to my branch. Tldr: my PR should be merged |
|
Could you review it again when possible? I’d appreciate it @felix-ht |
irvine5k
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
irvine5k
had a problem deploying
to
ANDROID_CI_DOWNLOADS_TOKEN
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Flutter stable version (3.27.0) bumps the version of Dart, and the new version removed the function
hashValueswhich breaks apps that just upgraded to Flutter 3.27.0.It's recommended to move to
Object.hashflutter/flutter#96109